Conversation
0072aa9 to
4478007
Compare
Contributor
size-limit report 📦
|
mydea
reviewed
Apr 9, 2024
| }, | ||
| spanNameHook(info, defaultName) { | ||
| if (getIsolationScope() === getDefaultIsolationScope()) { | ||
| logger.warn('Isolation scope is still default isolation scope - skipping setting transactionName'); |
Member
There was a problem hiding this comment.
l: should we add DEBUG_BUILD && here?
mydea
approved these changes
Apr 9, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
very nice catch! That's actually a huge fix, great find!
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…ng spans (getsentry#11503) Our Http instrumentation didn't clone the isolation scope correctly when the request span is not recording. We early returned if the span was not a server kind span. However, non-recording spans apparently have no span kind, so we wrongfully early returned in the check for non-recording spans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that our Http instrumentation doesn't clone the isolation scope correctly when the request span is not recording.
The reason is that we early returned if the span was not a server kind span. However, non-recording spans apparently have no span kind, so we wrongfully early returned in the check for non-recording spans.
This probably led to pollution of the default isolation scope. Added tests to demonstrate the fixed behaviour.