feat: Rename ESM loader hooks to import and loader#11498
Merged
Conversation
Collaborator
|
When I first saw the two new paths, they read as exactly the same string for me for a good few seconds. I think this is partly because I wasn't fully caffeinated but also because they're the same length and both end in
Maybe they're better without
|
timfish
approved these changes
Apr 9, 2024
Member
|
For me omiting |
AbhiPrasad
approved these changes
Apr 11, 2024
Contributor
Author
|
Changed to omitting the |
import-hook and loader-hookimport and loader
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback in #11338 (comment) I decided it would make sense to rename our ESM hooks to something that is more in line with the Node.js interface to register the hooks.
Old
node --loader=@sentry/node/hook app.jsnode --import=@sentry/node/register app.jsNew
node --loader=@sentry/node/loader app.jsnode --import=@sentry/node/import app.js