feat(core): Allow to pass scope to withIsolationScope()#11478
Merged
Conversation
lforst
approved these changes
Apr 8, 2024
Contributor
size-limit report 📦
|
Also adds tests for this for core, vercel-edge and opentelemetry. NOTE: In core, this does not do anything, as we cannot actually update the isolation scope in browser. Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
9470c65 to
d31850c
Compare
s1gr1d
reviewed
Apr 8, 2024
Member
There was a problem hiding this comment.
L: The tests of describe('withScope() ... are the same in those 3 files, right?
Would it make sense to export them from a single source and use the tests in those 3 files? I am just thinking that we could add/remove tests in e.g. opentelemetry in the future and then it might not be straight forward that it also should be tested in core and vercel-edge
Member
Author
There was a problem hiding this comment.
yeah, we don't really export any tests etc. right now. IMHO it's OK to just have them duplicated, we can look into potentially streamlining this in the future!
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…11478) Also adds tests for this for core, vercel-edge and opentelemetry. NOTE: In core, this does not do anything, as we cannot actually update the isolation scope in browser. Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds tests for this for core, vercel-edge and opentelemetry.
NOTE: In core, this does not do anything, as we cannot actually update the isolation scope in browser.