feat(core): Implement suppressTracing#11468
Merged
Conversation
Lms24
approved these changes
Apr 8, 2024
Contributor
|
We need a browser version of this utility. The symbolification in Next.js is isomorphic. |
Member
Author
damn, I guess we'll need to put this on the ACS then, as this means we'll have to export this from core and use a different implementation. will look into it! |
Contributor
|
I don't think ACS is the right place tbh. Can we just have two different exports that have the exact same interface? |
This exports a new `suppressTracing` utility from `@sentry/opentelemetry` which can be used to wrap a callback to avoid tracing inside of it. We use this for bun transport, and for nextjs error symbolication.
702d5d9 to
65d4c30
Compare
suppressTracing
Contributor
size-limit report 📦
|
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This implements a new `suppressTracing` method which can be used to
ensure we do not send any spans inside of a callback.
Usage:
```js
await suppressTracing(() => {
// do not capture any spans for this fetch!
return fetch(...);
});
```
This also changes the behavior of starting child spans slightly to
actually create `NonRecordingSpan` as child spans when not sampled
(previously, we'd still create SentrySpans). I choose to continue to
create proper spans for unsampled transactions because it makes things
like picking name and stuff like this easier for the time being.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a new
suppressTracingmethod which can be used to ensure we do not send any spans inside of a callback.Usage:
This also changes the behavior of starting child spans slightly to actually create
NonRecordingSpanas child spans when not sampled (previously, we'd still create SentrySpans). I choose to continue to create proper spans for unsampled transactions because it makes things like picking name and stuff like this easier for the time being.