Skip to content

feat(sveltekit): Update scope transactionName when pageload route name is updated#11406

Merged
Lms24 merged 4 commits intodevelopfrom
lms/feat-sveltekit-update-scope-transactionName
Apr 4, 2024
Merged

feat(sveltekit): Update scope transactionName when pageload route name is updated#11406
Lms24 merged 4 commits intodevelopfrom
lms/feat-sveltekit-update-scope-transactionName

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Apr 3, 2024

Our SvelteKit routing instrumentation updates the pageload rootspan name once we obtain the parameterized route id. This PR now also updates the scope's transactionName at this point.

ref #10846

@Lms24 Lms24 force-pushed the lms/feat-sveltekit-update-scope-transactionName branch from 28f6742 to 0b87667 Compare April 3, 2024 15:45
@Lms24 Lms24 requested review from AbhiPrasad and mydea April 3, 2024 15:45
@Lms24 Lms24 self-assigned this Apr 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 76.07 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.34 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 71.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.9 KB (0%)
@sentry/browser (incl. Tracing) 32 KB (0%)
@sentry/browser (incl. browserTracingIntegration) 32 KB (0%)
@sentry/browser (incl. feedbackIntegration) 31.28 KB (0%)
@sentry/browser (incl. feedbackModalIntegration) 31.39 KB (0%)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.39 KB (0%)
@sentry/browser (incl. sendFeedback) 27.35 KB (0%)
@sentry/browser 22.52 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.09 KB (0%)
CDN Bundle (incl. Tracing, Replay) 65.8 KB (0%)
CDN Bundle (incl. Tracing) 32.14 KB (0%)
CDN Bundle 23.74 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 205.04 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 95.75 KB (0%)
CDN Bundle - uncompressed 70.05 KB (0%)
@sentry/react (incl. Tracing, Replay) 67.31 KB (0%)
@sentry/react 22.55 KB (0%)

@Lms24 Lms24 merged commit a132d5c into develop Apr 4, 2024
@Lms24 Lms24 deleted the lms/feat-sveltekit-update-scope-transactionName branch April 4, 2024 09:36
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…ame is updated (getsentry#11406)

Our SvelteKit routing instrumentation updates the pageload rootspan name
once we obtain the parameterized route id. This patch now also updates the
scope's `transactionName` at this point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants