Skip to content

ref(v8): Remove args on HandlerDataXhr#11373

Merged
mydea merged 1 commit intodevelopfrom
fn/remove-handler-xhr-args
Apr 2, 2024
Merged

ref(v8): Remove args on HandlerDataXhr#11373
mydea merged 1 commit intodevelopfrom
fn/remove-handler-xhr-args

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Apr 2, 2024 •
edited
Loading

This is not used anymore and can/should be handled differently.

You can read this data from the SentryXhrData instead, if necessary (which will hold the up-to-date information for this XHR request).

@mydea mydea requested review from AbhiPrasad and Lms24 April 2, 2024 11:45
@mydea mydea self-assigned this Apr 2, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 57.58kB ⬆️

Bundle name Size Change
@sentry/types-cjs 35 bytes 0 bytes
@sentry/types-esm 35 bytes 0 bytes
@sentry/utils-cjs 178.66kB 90 bytes ⬇️
@sentry-internal/integration-shims-cjs 3.65kB 0 bytes
@sentry-internal/feedback-cjs 65.81kB 0 bytes
@sentry/utils-esm 174.08kB 90 bytes ⬇️
@sentry-internal/integration-shims-esm 2.99kB 0 bytes
@sentry-internal/feedback-esm 65.5kB 0 bytes
@sentry/opentelemetry-esm 67.4kB 0 bytes
@sentry/node-esm 333.56kB 0 bytes
@sentry-internal/tracing-esm 107.26kB 0 bytes
@sentry/vercel-edge-cjs 18.23kB 0 bytes
@sentry/core-cjs 240.44kB 0 bytes
@sentry/opentelemetry-cjs 68.45kB 0 bytes
@sentry/vercel-edge-esm 16.13kB 0 bytes
@sentry-internal/replay-cjs 306.35kB 0 bytes
@sentry-internal/tracing-cjs 108.01kB 0 bytes
@sentry/core-esm 236.82kB 0 bytes
@sentry-internal/replay-esm 306.46kB 0 bytes
@sentry/node-cjs 336.97kB 0 bytes
@sentry-internal/replay-canvas-cjs 29.51kB 0 bytes
@sentry/browser-esm 104.53kB 0 bytes
@sentry/aws-serverless-cjs 14.62kB 0 bytes
@sentry/google-cloud-serverless-esm 19.16kB 0 bytes
@sentry/browser-cjs 107.36kB 0 bytes
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry/wasm-cjs 5.2kB 0 bytes
@sentry/vue-cjs 20.19kB 0 bytes
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/gatsby-cjs 905 bytes 0 bytes
@sentry/vue-esm 18.85kB 0 bytes
@sentry-internal/replay-canvas-esm 29.43kB 0 bytes
@sentry/bun-cjs 13.5kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/gatsby-esm 385 bytes 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/svelte-cjs 13.84kB 0 bytes
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry/react-cjs 45.04kB 45.04kB ⬆️
@sentry/bun-esm 10.05kB 0 bytes
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/wasm-esm 4.85kB 0 bytes
@sentry/google-cloud-serverless-cjs 23.0kB 0 bytes
@sentry/svelte-esm 12.72kB 12.72kB ⬆️
@sentry/react-esm 41.18kB 0 bytes
@sentry/astro-cjs 27.13kB 0 bytes
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.45 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) 71.79 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.6 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.35 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) 36.61 KB (-0.04% 🔽)
@sentry/browser (incl. browserTracingIntegration) 36.61 KB (-0.04% 🔽)
@sentry/browser (incl. feedbackIntegration) 31.51 KB (-0.05% 🔽)
@sentry/browser (incl. feedbackModalIntegration) 31.62 KB (-0.04% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.63 KB (-0.04% 🔽)
@sentry/browser (incl. sendFeedback) 27.58 KB (-0.05% 🔽)
@sentry/browser 22.74 KB (-0.07% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.9 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.72 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing) 36.26 KB (-0.04% 🔽)
CDN Bundle 24.01 KB (-0.06% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.78 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 109.42 KB (-0.03% 🔽)
CDN Bundle - uncompressed 71.05 KB (-0.05% 🔽)
@sentry/react (incl. Tracing, Replay) 71.77 KB (-0.03% 🔽)
@sentry/react 22.77 KB (-0.07% 🔽)

@mydea
ref(v8): Remove args on HandlerDataXhr
01b12bf 
This is not used anymore and can/should be handled differently.
@mydea mydea force-pushed the fn/remove-handler-xhr-args branch from f5d4086 to 01b12bf Compare April 2, 2024 11:59
Lms24
Lms24 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Would you mind adding a quick sentence to the PR what the replacement generally is? I don't know myself and it's probably good context for the future.

@mydea mydea merged commit 9fa6c44 into develop Apr 2, 2024
@mydea mydea deleted the fn/remove-handler-xhr-args branch April 2, 2024 13:55
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@mydea @cadesalaberry
ref(v8): Remove args on HandlerDataXhr (getsentry#11373)
35004c0 
This is not used anymore and can/should be handled differently.

You can read this data from the `SentryXhrData` instead, if necessary
(which will hold the up-to-date information for this XHR request).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea @Lms24