ref(v7): Deprecate addRequestDataToTransaction#11368
Merged
Conversation
This is not used/needed anymore in v8, and also is coupled to transactions.
Lms24
reviewed
Apr 2, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Utils package technically doesn't even guarantee semver so I think this is perfectly fine!
Lms24
approved these changes
Apr 2, 2024
AbhiPrasad
pushed a commit
that referenced
this pull request
Apr 2, 2024
See #11368, where this is deprecated on v7.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
See getsentry#11368, where this is deprecated on v7.
This was referenced Jun 3, 2024
This was referenced Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not used/needed anymore in v8, and also is coupled to transactions.
Not sure if we need to add this to migration docs, as this is from utils and was more internally used...? (Also, I guess if so we need to add it to migration docs in a separate PR on develop...?)