docs: Fix paths in readme to point to proper files#11364
Merged
Conversation
Lms24
approved these changes
Apr 2, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This was noticed here: getsentry#11337 (comment), when viewed on e.g. npmjs.org the relative links to do not work, so we should have full URLs only in the readme files. It would be _nicer_ if we could replace this with a proper full URL at release time to point to the correct version of the file, but that's more work and probably not worth it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was noticed here: #11337 (comment), when viewed on e.g. npmjs.org the relative links to do not work, so we should have full URLs only in the readme files.
It would be nicer if we could replace this with a proper full URL at release time to point to the correct version of the file, but that's more work and probably not worth it...