feat(v8): Remove data from SentrySpan & rename types#11303
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 53.18kB ⬆️
|
Contributor
size-limit report 📦
|
lforst
approved these changes
Mar 27, 2024
This removes `data` from the span (there is only `attributes` left). Also, for clarity, I renamed `SpanContext` to `SentrySpanArguments`, and `TransactionContext` to `TransactionArguments`, as "Context" is heavily overloaded and IMHO this is confusing today.
ebd79c2 to
bf49286
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…1303) This removes `data` from the span (there is only `attributes` left). Also, for clarity, I renamed `SpanContext` to `SentrySpanArguments`, and `TransactionContext` to `TransactionArguments`, as "Context" is heavily overloaded and IMHO this is confusing today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
datafrom the span (there is onlyattributesleft). Also, for clarity, I renamedSpanContexttoSentrySpanArguments, andTransactionContexttoTransactionArguments, as "Context" is heavily overloaded and IMHO this is confusing today.