ref(angular): Don't include BrowserApiErrors in bundle#11294
Merged
AbhiPrasad merged 2 commits intodevelopfrom Mar 27, 2024
Merged
ref(angular): Don't include BrowserApiErrors in bundle#11294AbhiPrasad merged 2 commits intodevelopfrom
AbhiPrasad merged 2 commits intodevelopfrom
Conversation
Closed
mydea
approved these changes
Mar 27, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
m: Can we add a comment next to getDefaultIntegrations in browser to remember to update the list in angular as well, when it is changed? To ensure we don't forget to keep these in sync?
6add689 to
606c389
Compare
Contributor
Author
Great idea!! done with 606c389 |
Bundle ReportChanges will increase total bundle size by 2.57kB ⬆️
|
Contributor
size-limit report 📦
|
Lms24
reviewed
Mar 28, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
ref getsentry#9508 The `BrowserApiErrors` integration interfers with Angular error handler, so don't include it in the default integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #9508
The
BrowserApiErrorsintegration interfers with Angular error handler, so don't include it in the default integrations.