feat(node): Add scope to ANR events#11256
Merged
AbhiPrasad merged 6 commits intodevelopfrom Mar 25, 2024
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 28, 2024
Backport of #11256 Scope wasn't working for the deprecated export (pre. integration) so I didn't spend any time trying to fix it and just don't test this scope feature for that.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Closes getsentry#10668 Rather than inject large unchecked JavaScript strings to run via `Runtime.evaluate`, when the ANR integration is enabled, we add a function to `global.__SENTRY_GET_SCOPES__` which can then be called via the debugger when the event loop is suspended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10668
Rather than inject large unchecked JavaScript strings to run via
Runtime.evaluate, when the ANR integration is enabled, we add a function toglobal.__SENTRY_GET_SCOPES__which can then be called via the debugger when the event loop is suspended.