feat(browser): Make fetch the default transport for offline#11209
Merged
AbhiPrasad merged 2 commits intodevelopfrom Mar 21, 2024
Merged
feat(browser): Make fetch the default transport for offline#11209AbhiPrasad merged 2 commits intodevelopfrom
AbhiPrasad merged 2 commits intodevelopfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
AbhiPrasad
reviewed
Mar 20, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Can you write an entry in MIGRATION.md?
Collaborator
Author
|
I don't think this needs to be in |
AbhiPrasad
approved these changes
Mar 21, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…y#11209) Now we only have one included transport, this simplifies the vast majority of use cases: Before: ```ts import { init, makeBrowserOfflineTransport, makeFetchTransport } from "@sentry/browser"; init({ dsn: "__DSN__", transport: makeBrowserOfflineTransport(makeFetchTransport) }) ``` After: ```ts import { init, makeBrowserOfflineTransport } from "@sentry/browser"; init({ dsn: "__DSN__", transport: makeBrowserOfflineTransport() }) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we only have one included transport, this simplifies the vast majority of use cases:
Before:
After: