fix(attachments): Add missing view_hierarchy attachment type#11197
Merged
krystofwoldrich merged 2 commits intodevelopfrom Mar 20, 2024
Merged
fix(attachments): Add missing view_hierarchy attachment type#11197krystofwoldrich merged 2 commits intodevelopfrom
view_hierarchy attachment type#11197krystofwoldrich merged 2 commits intodevelopfrom
Conversation
timfish
approved these changes
Mar 19, 2024
Contributor
size-limit report 📦
|
Lms24
approved these changes
Mar 19, 2024
AbhiPrasad
approved these changes
Mar 19, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Needs to be part of v7 as well?
Contributor
|
Let's also make sure we update https://develop.sentry.dev/sdk/envelopes/#attachment |
Contributor
Author
Yes, is there v7 branch or how do we backport items? |
Contributor
Author
Member
Yes, I recommend cherry-picking the commit and opening a second PR against |
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing view hierarchy attachment type used in React Native.