Skip to content

feat(v8/core): Remove deprecated client.setupIntegrations method#11179

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-client-setupIntegrations
Mar 19, 2024
Merged

feat(v8/core): Remove deprecated client.setupIntegrations method#11179
AbhiPrasad merged 1 commit intodevelopfrom
abhi-client-setupIntegrations

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented Mar 18, 2024 •
edited
Loading

ref #10100

@AbhiPrasad AbhiPrasad requested a review from a team March 18, 2024 20:11
@AbhiPrasad AbhiPrasad self-assigned this Mar 18, 2024
@AbhiPrasad AbhiPrasad requested review from Lms24 and mydea and removed request for a team March 18, 2024 20:11
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 18, 2024
Closed
@AbhiPrasad AbhiPrasad force-pushed the abhi-client-setupIntegrations branch from 0bb5cfb to c3ec59b Compare March 18, 2024 20:11
@AbhiPrasad AbhiPrasad force-pushed the abhi-client-setupIntegrations branch from c3ec59b to 716f779 Compare March 18, 2024 20:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.69 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.04 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.85 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.61 KB (added)
@sentry/browser (incl. Tracing) 36.65 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.65 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.32 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.44 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (added)
@sentry/browser (incl. sendFeedback) 27.41 KB (added)
@sentry/browser 22.58 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.03 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.88 KB (added)
CDN Bundle (incl. Tracing) 36.24 KB (added)
CDN Bundle 23.95 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.5 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.44 KB (added)
CDN Bundle - uncompressed 70.97 KB (added)
@sentry/react (incl. Tracing, Replay) 72.04 KB (added)
@sentry/react 22.61 KB (added)

Lms24
Lms24 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check, do we have test for client.init that cover the deleted tests?

@AbhiPrasad
Copy link
Copy Markdown
Contributor Author

AbhiPrasad commented Mar 19, 2024

Just to check, do we have test for client.init that cover the deleted tests?

Yes we do! They are in the same test file.

@AbhiPrasad AbhiPrasad merged commit f460899 into develop Mar 19, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-client-setupIntegrations branch March 19, 2024 13:14
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/core): Remove deprecated client.setupIntegrations method (get…
bb29e8a 
…sentry#11179)

ref getsentry#11177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-javascript-sdks

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad @Lms24