feat(remix): Skip span creation for OPTIONS and HEAD requests.#11149
Merged
AbhiPrasad merged 1 commit intodevelopfrom Apr 8, 2024
Merged
feat(remix): Skip span creation for OPTIONS and HEAD requests.#11149AbhiPrasad merged 1 commit intodevelopfrom
OPTIONS and HEAD requests.#11149AbhiPrasad merged 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Mar 18, 2024
Member
@onurtemizkan just before I merge this, would you mind explaining why these are the requests mentioned in the issue/discord? I'm probably missing some context here and I'm curious how you identified it. |
Contributor
Author
|
@Lms24, looking again, I'm now not sure if this completely resolves all the cases mentioned in the linked issue. That's a misunderstanding on my side. I have seen a polluted transaction list caused by I'm converting the PR to draft now, I'll try to experiment with the external requests and update the patch accordingly. Thanks for the review! |
Member
|
Ok makes sense, thanks for double checking! |
d984176 to
de88797
Compare
de88797 to
2f2f831
Compare
AbhiPrasad
approved these changes
Apr 8, 2024
Contributor
|
Do we want to backport to v7? |
Contributor
Author
Yes, I think so, I'll open a PR. |
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…etsentry#11149) Fixes: getsentry#11105 Skips span creation for `OPTIONS` and `HEAD` requests in `wrapRequestHandler`, which apparently are the unwanted requests mentioned in getsentry#11105. We can also implement a more precise filtering but this seems to resolve it on my local test application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11105
Skips span creation for
OPTIONSandHEADrequests inwrapRequestHandler, which apparently are the unwanted requests mentioned in #11105. We can also implement a more precise filtering but this seems to resolve it on my local test application.