Skip to content

test: Re-enable flaky replay tests#11140

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-re-enable-replay-flaky-tests
Mar 15, 2024
Merged

test: Re-enable flaky replay tests#11140
AbhiPrasad merged 1 commit intodevelopfrom
abhi-re-enable-replay-flaky-tests

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented Mar 15, 2024 •
edited
Loading

closes #11136
closes #11062
closes #11137
closes #11138
closes #11139

In #11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here.

Note that Detect flaky tests / Check tests for flakiness runs on the smaller workers, so it'll experience the same issues we had before.

@AbhiPrasad AbhiPrasad self-assigned this Mar 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.19 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.52 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.33 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.07 KB (added)
@sentry/browser (incl. Tracing) 38.15 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.15 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.01 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.09 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.1 KB (added)
@sentry/browser (incl. sendFeedback) 29.08 KB (added)
@sentry/browser 24.25 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.57 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.43 KB (added)
CDN Bundle (incl. Tracing) 37.77 KB (added)
CDN Bundle 25.62 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.88 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 113.82 KB (added)
CDN Bundle - uncompressed 75.66 KB (added)
@sentry/react (incl. Tracing, Replay) 73.51 KB (added)
@sentry/react 24.27 KB (added)

@AbhiPrasad AbhiPrasad marked this pull request as ready for review March 15, 2024 17:56
@AbhiPrasad AbhiPrasad requested review from a team, billyvg, mydea and s1gr1d and removed request for a team March 15, 2024 17:56
@AbhiPrasad AbhiPrasad merged commit 0a54d19 into develop Mar 15, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-re-enable-replay-flaky-tests branch March 15, 2024 18:08
billyvg added a commit that referenced this pull request Mar 15, 2024
@billyvg
test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests
a597ea0 
See #11140
@billyvg billyvg mentioned this pull request Mar 15, 2024
Merged
billyvg added a commit that referenced this pull request Apr 15, 2024
@billyvg
test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests
7d59b6f 
See #11140
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
test: Re-enable flaky replay tests (getsentry#11140)
ed61ca6 
closes getsentry#11136
closes getsentry#11062
closes getsentry#11137
closes getsentry#11138
closes getsentry#11139

In getsentry#11134 we changed
the playwright tests use a larger GH runner. This should hopefully fix
the flaky replay playwright tests. Validating that here.

Note that `Detect flaky tests / Check tests for flakiness` runs on the
smaller workers, so it'll experience the same issues we had before.
billyvg added a commit that referenced this pull request May 13, 2024
@billyvg @mydea
test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests (#11142)
1390402 
See #11140


Closes #9119

---------

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
andreiborza pushed a commit that referenced this pull request May 16, 2024
@billyvg @mydea @andreiborza
test(replay): Fix flakey extendNetworkBreadcrumbs/fetch tests (#11142)
6ce0841 
See #11140


Closes #9119

---------

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment