build(remix): Skip Node 18 & 16 integration tests because they often segfault#11107
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 14, 2024
Merged
build(remix): Skip Node 18 & 16 integration tests because they often segfault#11107AbhiPrasad merged 1 commit intodevelopfrom
AbhiPrasad merged 1 commit intodevelopfrom
Conversation
lforst
approved these changes
Mar 14, 2024
onurtemizkan
approved these changes
Mar 14, 2024
Contributor
onurtemizkan
left a comment
There was a problem hiding this comment.
I'll try to get to the root of this.
Contributor
|
merging this in because I can't even merge changelog without it :( |
Lms24
pushed a commit
that referenced
this pull request
Mar 18, 2024
Ref: #11107 Removes `--detectOpenHandles` from Jest configurations of Remix and Next.JS which apparently causes segfault. Re-enables Remix Node 16 and Node 18 integration tests on CI
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…ry#11148) Ref: getsentry#11107 Removes `--detectOpenHandles` from Jest configurations of Remix and Next.JS which apparently causes segfault. Re-enables Remix Node 16 and Node 18 integration tests on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. see https://github.com/getsentry/sentry-javascript/actions/runs/8283620197/job/22667464126?pr=11106