fix(ember): Ensure browser tracing is correctly lazy loaded#11026
Merged
fix(ember): Ensure browser tracing is correctly lazy loaded#11026
Conversation
This was referenced Mar 11, 2024
Lms24
approved these changes
Mar 11, 2024
Contributor
|
Does this need to be backported to v7? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that this is tree shaken weirdly through the async await import, for some reason. Maybe we can overall refactor this to instead use build time flags (instead of async import) but I'll look into this separately, possibly.
I was able to reproduce this with a small local app, and this seemed to fix it.
Closes #10566