feat(browser): Use idle span for browser tracing#10957
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Mar 7, 2024
Contributor
There was a problem hiding this comment.
Generally looks super good to me! There is one point that needs adressing: #10957 (comment).
Comment on lines
+119
to
+121
| const endTimestamp = latestEndTimestamp | ||
| ? Math.min(spanTimeInputToSeconds(timestamp), latestEndTimestamp) | ||
| : timestamp; |
Contributor
There was a problem hiding this comment.
Something looks off here. In one case we take spanTimeInputToSeconds(timestamp), in the other case we take timestamp.
Member
Author
There was a problem hiding this comment.
this is fine here because we only need to convert it to a seconds timestamp for Math.min() to work reliably, otherwise we can just pass the input through whatever it is!
Contributor
There was a problem hiding this comment.
Ok, I assume because we convert it to the right unit downstream somewhere? Would you mind adding a (short) comment? This might confuse the next person coming across this ^^
Member
Author
There was a problem hiding this comment.
updated the whole code block a bit to hopefully clarify thigns!
packages/tracing-internal/src/browser/browserTracingIntegration.ts
Outdated
Show resolved
Hide resolved
packages/tracing-internal/src/browser/browserTracingIntegration.ts
Outdated
Show resolved
Hide resolved
lforst
reviewed
Mar 7, 2024
AbhiPrasad
approved these changes
Mar 7, 2024
And remove idle transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove idle transaction.
With this, we can afterwards remove the span recorder, and everything related to it 🎉
I tried to keep all functionality intact. Some small cleanups I made:
trimEndoption - we always set this to true anyhow). However, this only applies when the span is auto-ended by the idle functionality, not if manually callingspan.end()- which is fine IMHO because that will usually not happen for users, and even so it's not the end of the world.continueTracefor trace propagation of the pageload span.locationon the sampling context - we talked about this before, this is just gone, and users can instead either access the attributes from the sampling context, or just dowindow.location.hrefthemselves, which should have the same outcome.