feat(core): Allow metrics aggregator per client#10949
Merged
AbhiPrasad merged 3 commits intodevelopfrom Mar 6, 2024
Merged
Conversation
Collaborator
Author
|
I'm half tempted to make it the last function parameter with a default of function increment(name: string, value: number = 1, data?: MetricData, client: Client = getClient()): void { |
Contributor
size-limit report 📦
|
AbhiPrasad
reviewed
Mar 6, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
I don't mind passing client into the data bag, I'd rather not introduce an additional function argument.
AbhiPrasad
approved these changes
Mar 6, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Do we have to backport this to v7?
AbhiPrasad
reviewed
Mar 6, 2024
| /** | ||
| * @ignore This is for internal use only. | ||
| */ | ||
| getMetricsAggregatorForClient, |
Contributor
There was a problem hiding this comment.
Actually should we export this as a separate method to help with treeshaking?
Collaborator
Author
There was a problem hiding this comment.
The getMetricsAggregatorForClient function is in the call chain for all the other Sentry.metrics.* functions so there will be no impact to tree shaking.
Collaborator
Author
Unlikely! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to override the client used for metrics rather than being tied to using the single client
getClient()returns.It also adds a
getMetricsAggregatorForClientexported function which is required so the Electron SDK can access the current aggregator.sendEnvelopewas added to theClienttype so that all usages ofBaseClient<ClientOptions>could be replaced withClient.