ref(ember): Avoid namespace import to hopefully resolve minification issue#10885
Merged
ref(ember): Avoid namespace import to hopefully resolve minification issue#10885
Conversation
…issue Not sure if this will change stuff, but maybe this is tree shaken away incorrectly there, for whatever reason... let's try to see if this helps with things!
s1gr1d
approved these changes
Mar 1, 2024
Member
s1gr1d
left a comment
There was a problem hiding this comment.
Let's hope this fixes the issue! 👍🏻
Closed
This was referenced Mar 12, 2024
This was referenced Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this actually fixes this issue: #10566 🤔 Maybe the internal bundler is thrown off by the fact that we lazy load browser tracing further below, and only includes certain things in
Sentryon top, not sure...