Skip to content

feat(v8): Remove deprecated runWithAsyncContext API#10780

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-runWithAsyncContext
Feb 22, 2024
Merged

feat(v8): Remove deprecated runWithAsyncContext API#10780
AbhiPrasad merged 1 commit intodevelopfrom
abhi-runWithAsyncContext

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

ref #10100

@AbhiPrasad AbhiPrasad requested review from a team, mydea and s1gr1d and removed request for a team February 21, 2024 21:19
@AbhiPrasad AbhiPrasad self-assigned this Feb 21, 2024
@AbhiPrasad AbhiPrasad merged commit 32e4eff into develop Feb 22, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-runWithAsyncContext branch February 22, 2024 14:16
@nwalters512
Copy link
Copy Markdown
Contributor

nwalters512 commented May 13, 2024

@AbhiPrasad there's no mention of this change in either the in-repo migration guide (https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md) or the one on your docs website (https://docs.sentry.io/platforms/javascript/migration/v7-to-v8). Why was this removed and what can we replace it with? I see from the deleted that the answer to this is Sentry.withScope(), but this information really belongs in the migration guide.

@AbhiPrasad
Copy link
Copy Markdown
Contributor Author

@nwalters512 yes you're right! this is something we missed. I will fix docs accordingly, sorry for the trouble.

@AbhiPrasad
Copy link
Copy Markdown
Contributor Author

opened a migration doc PR here: #12153, will update docs tomorrow given I have to sign off for today!

mydea pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants