Fixes latest route name and source not updating correctly#10702
Merged
edwardgou-sentry merged 2 commits intov7from Feb 22, 2024
Merged
Fixes latest route name and source not updating correctly#10702edwardgou-sentry merged 2 commits intov7from
edwardgou-sentry merged 2 commits intov7from
Conversation
Contributor
Author
|
Planning to use this as a route name tag on inp spans. |
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Feb 20, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
nice, this bug was annoying
mydea
added a commit
that referenced
this pull request
Apr 10, 2024
mydea
added a commit
that referenced
this pull request
Apr 11, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latestRouteNameandlatestRouteSourceare immutable strings, so handlers that use these strings do not get the proper latest values when a route update occurs. This update puts the route name and source in an object. Fixes an issue with interaction transactions always using the first pageload transaction route name even though the user has navigated away from the first route name.