Skip to content

fix(feedback): Replay breadcrumb for feedback events was incorrect#10536

Merged
billyvg merged 1 commit intodevelopfrom
fix-feedback-fix-types-and-feedback-breadcrumb-structure
Feb 7, 2024
Merged

fix(feedback): Replay breadcrumb for feedback events was incorrect#10536
billyvg merged 1 commit intodevelopfrom
fix-feedback-fix-types-and-feedback-breadcrumb-structure

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented Feb 6, 2024

We are creating a replay breadcrumb when user feedback was submitted, however, the it was not typed correctly, which the timestamp not being included in the proper location.

@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Feb 6, 2024 •
edited
Loading

Does this need to go out before v8? I'm planning on a v7 patch release to get out a profiling fix, I can backport these changes onto it too.

@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Feb 6, 2024

@AbhiPrasad yeah we could backport it, this is not super high priority though -- when are you aiming for the next release?

@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Feb 6, 2024

yeah we could backport it, this is not super high priority though -- when are you aiming for the next release?

Whenever #10534 can merge and pass CI, hopefully tomorrow

@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Feb 6, 2024

yeah we could backport it, this is not super high priority though -- when are you aiming for the next release?

Whenever #10534 can merge and pass CI, hopefully tomorrow

Should I make a PR w/ v7 as base branch?

@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Feb 6, 2024

Should I make a PR w/ v7 as base branch?

Merge it into develop first, we'll cherry-pick it onto v7.

@billyvg billyvg marked this pull request as ready for review February 6, 2024 22:07
@billyvg billyvg requested a review from a team February 6, 2024 22:07
@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Feb 6, 2024

#10534 was merged in, whenever you merge this PR in I'll backport and make a v7 release.

@AbhiPrasad AbhiPrasad mentioned this pull request Feb 6, 2024
Closed
3 tasks
@billyvg billyvg enabled auto-merge (squash) February 6, 2024 23:26
@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Feb 7, 2024

#10542 should fix the CI issues with profiling.

@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Feb 7, 2024 

[16/285] [chromium] › integrations/httpclient/fetch/withRequest/test.ts:7:11 › works with a Request passed in
  1) [chromium] › integrations/Breadcrumbs/dom/click/test.ts:7:11 › captures Breadcrumb for clicks & debounces them for a second 

    Error: page.evaluate: ReferenceError: Sentry is not defined

        at eval (eval at evaluate (:226:30), <anonymous>:1:1)
        at eval (<anonymous>)
        at UtilityScript.evaluate (<anonymous>:226:30)
        at UtilityScript.<anonymous> (<anonymous>:1:44)
        at eval (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/eval at evaluate (:226:30), <anonymous>:1:1)
        at UtilityScript.evaluate (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/<anonymous>:226:30)
        at UtilityScript.<anonymous> (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/<anonymous>:1:44)
        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/test.ts:37:56

🤔

@billyvg @mydea
fix(feedback): Replay breadcrumb for feedback events was incorrect
9e94314 
We are creating a replay breadcrumb when user feedback was submitted, however, the it was not typed correctly, which the timestamp not being included in the proper location.
@mydea mydea force-pushed the fix-feedback-fix-types-and-feedback-breadcrumb-structure branch from 802cc3c to 9e94314 Compare February 7, 2024 08:05
@billyvg billyvg merged commit fa4669a into develop Feb 7, 2024
@billyvg billyvg deleted the fix-feedback-fix-types-and-feedback-breadcrumb-structure branch February 7, 2024 08:25
mydea pushed a commit that referenced this pull request Feb 7, 2024
@billyvg @mydea
fix(feedback): Replay breadcrumb for feedback events was incorrect (#…
11576d6 
…10536)

We are creating a replay breadcrumb when user feedback was submitted,
however, the it was not typed correctly, which the timestamp not being
included in the proper location.
@mydea mydea mentioned this pull request Feb 7, 2024
Merged
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 7, 2024
Closed
This was referenced Feb 12, 2024
Closed
Merged
Closed
Merged
This was referenced Mar 12, 2024
Merged
Closed
@Lms24 Lms24 mentioned this pull request Mar 20, 2024
Merged
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
@Lms24 Lms24 mentioned this pull request Jun 4, 2024
Merged
@Lms24 Lms24 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@c298lee c298lee c298lee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg @AbhiPrasad @c298lee