Conversation
added 2 commits
February 5, 2024 11:34
… up the scopes at time of creation instead of termination
Contributor
size-limit report 📦
|
mydea
approved these changes
Feb 5, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
looks good to me! When we actually do v8 we should align using either weak maps or non-enumerable properties for all the stuff we have to relate to spans, but this is purely internal and I have no strong feelings on this either way. We can think about this some more..!
Contributor
Author
Agreed. I think I like non-enumerables a bit more because you can rely on them working across package boundaries without having to rely on getters-setters, meaning they won't widen the API surface in any way. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes spans/transactions created with
startSpan,startSpanManualandstartInactiveSpanuse data from the scopes that were active at the time these functions were called instead of using the scopes that are active when the span was.end()ed.We already do this in the otel compatible SDK and we deem this behaviour more intuitive than using the scopes on span finish.