Conversation
Comment on lines
+68
to
+99
| const sentryRequest = https.request( | ||
| sentryIngestUrl, | ||
| { headers: proxyRequest.headers, method: proxyRequest.method }, | ||
| sentryResponse => { | ||
| sentryResponse.addListener('data', (chunk: Buffer) => { | ||
| proxyResponse.write(chunk, 'binary'); | ||
| sentryResponseChunks.push(chunk); | ||
| }); | ||
|
|
||
| sentryResponse.addListener('end', () => { | ||
| eventCallbackListeners.forEach(listener => { | ||
| const rawSentryResponseBody = Buffer.concat(sentryResponseChunks).toString(); | ||
|
|
||
| const data: SentryRequestCallbackData = { | ||
| envelope: parseEnvelope(proxyRequestBody, new TextEncoder(), new TextDecoder()), | ||
| rawProxyRequestBody: proxyRequestBody, | ||
| rawSentryResponseBody, | ||
| sentryResponseStatusCode: sentryResponse.statusCode, | ||
| }; | ||
|
|
||
| listener(Buffer.from(JSON.stringify(data)).toString('base64')); | ||
| }); | ||
| proxyResponse.end(); | ||
| }); | ||
|
|
||
| sentryResponse.addListener('error', err => { | ||
| throw err; | ||
| }); | ||
|
|
||
| proxyResponse.writeHead(sentryResponse.statusCode || 500, sentryResponse.headers); | ||
| }, | ||
| ); |
Check failure
Code scanning / CodeQL
Server-side request forgery
Lms24
commented
Feb 2, 2024
| ".angular/**", | ||
| "angular.json" | ||
| "angular.json", | ||
| "ember/instance-initializers/**", |
Member
Author
There was a problem hiding this comment.
had some biome errors for ember files. decided to ignore these for now
mydea
approved these changes
Feb 2, 2024
Lms24
commented
Feb 2, 2024
Comment on lines
+67
to
+71
| transaction_info: { | ||
| // So this is weird. The source is set to custom although the route doesn't have a name. | ||
| // This also only happens during a navigation. A pageload will set the source as 'route'. | ||
| // TODO: Figure out what's going on here. | ||
| source: 'custom', |
Member
Author
There was a problem hiding this comment.
Something to maybe tackle in or after #10477: For some reason we set source 'custom' during a navigation.
Not sure why this is happening but IMO it should be 'route', also when navigating. My guess is it's because we set custom when we take the route name over the actual route "path". Probably this is an edge case, we just didn't test before.
cc @mydea if you find an easy fix for this. Otherwise we follow up on this later.
Contributor
size-limit report 📦
|
onurtemizkan
pushed a commit
that referenced
this pull request
Feb 4, 2024
This PR adds e2e tests for a Vue 3 app using `@sentry/vue` Specifically, we test - Catching an error - Pageload transaction - Navigation transaction - Preferring route name over route id
mydea
added a commit
that referenced
this pull request
Feb 5, 2024
This replaces the `vueRouterInstrumentation` and allows to deprecate browser tracing in the vue package. Waiting for #10476, then we should put these changes on top of the E2E test to verify it still works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds e2e tests for a Vue 3 app using
@sentry/vueSpecifically, we test