feat(node-experimental): Update tracing integrations to functional style#10443
Merged
feat(node-experimental): Update tracing integrations to functional style#10443
Conversation
AbhiPrasad
approved these changes
Jan 31, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
I'm very glad we have those integration tests
123cc93 to
2a739e2
Compare
Member
Author
Haha good that I double checked, this did not used to trigger node integration tests because |
onurtemizkan
pushed a commit
that referenced
this pull request
Feb 4, 2024
…yle (#10443) This refactors the node-experimental performance integrations to functional style. Importantly, it also slightly updates the options for httpIntegration & nativeNodeFetchIntegration, with what they can/should be in v8: * There is no way to disable span creation for them (this is pretty hacky to do, and prob. not needed - not allowing this simplifies this a lot) * You can define filters for incoming/outgoing requests to filter them fully - that will filter them both for breadcrumbs and spans. * spans are not created anyhow when tracing is disabled.
This was referenced Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the node-experimental performance integrations to functional style.
Importantly, it also slightly updates the options for httpIntegration & nativeNodeFetchIntegration, with what they can/should be in v8: