ci: Always run code formatting CI job (even for *.md only PRs)#10421
Merged
ci: Always run code formatting CI job (even for *.md only PRs)#10421
Conversation
Contributor
size-limit report 📦
|
b677f6e to
a99664a
Compare
Member
Author
|
Seems to be working here: https://github.com/getsentry/sentry-javascript/actions/runs/7713096535 |
Lms24
reviewed
Jan 30, 2024
| DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }} | ||
| - name: Lint source files | ||
| run: yarn lint | ||
| run: yarn lint:lerna |
Member
There was a problem hiding this comment.
IIUC this command not only lints but actually fixes issues. Do we want this here?
Member
Author
There was a problem hiding this comment.
no, that's a different command (yarn fix / yarn fix:lerna)!
AbhiPrasad
approved these changes
Jan 30, 2024
andreiborza
added a commit
that referenced
this pull request
Dec 18, 2025
Fixes issue where job_build would run for PRs that only change markdown files. This was accidentally broken in #10421 when the changed_any_code check was removed from the last condition. This change restores the original behavior: markdown-only PRs will skip the build job while still running formatting checks in job_check_format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This runs a separate, streamlined lint step for prettier only, if only markdown files are changed.