Skip to content

feat(nextjs): Add browserTracingIntegration#10397

Merged
lforst merged 13 commits intodevelopfrom
lforst-nextjs-routing-instrumentation
Feb 2, 2024
Merged

feat(nextjs): Add browserTracingIntegration#10397
lforst merged 13 commits intodevelopfrom
lforst-nextjs-routing-instrumentation

Conversation

@lforst
Copy link
Copy Markdown
Contributor

@lforst lforst commented Jan 29, 2024 •
edited
Loading

Adds a wrapped browserTracingIntegration export to the Next.js package that transparently reuses the existing routing instrumentation.

Also deprecates the old BrowserTracing integration.

Ref #10387

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.15 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.38 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.3 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.99 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.38 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.66 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.5 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.01 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.63 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.73 KB (0%)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.35 KB (+0.99% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.57 KB (+1.52% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@lforst lforst mentioned this pull request Jan 31, 2024
Closed
@lforst lforst marked this pull request as ready for review January 31, 2024 15:33
@lforst lforst requested review from AbhiPrasad, Lms24 and mydea January 31, 2024 15:33
mydea
mydea reviewed Feb 2, 2024
View reviewed changes
.github/workflows/build.yml Outdated
needs: [job_get_metadata, job_build, job_e2e_prepare]
runs-on: ubuntu-20.04
timeout-minutes: 10
timeout-minutes: 20
Copy link
Copy Markdown
Member

@mydea mydea Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit long, but 🤷

Copy link
Copy Markdown
Contributor Author

@lforst lforst Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I'll try turning it back down.

@lforst lforst merged commit cfb1b60 into develop Feb 2, 2024
@lforst lforst deleted the lforst-nextjs-routing-instrumentation branch February 2, 2024 16:43
onurtemizkan pushed a commit that referenced this pull request Feb 4, 2024
@onurtemizkan
feat(nextjs): Add browserTracingIntegration (#10397)
fe096e8
@lforst lforst mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

+1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lforst @mydea @Lms24 @AbhiPrasad