test(tracing): Add test to validate that spans only added when active span exists#10376
Closed
AbhiPrasad wants to merge 5 commits intodevelopfrom
Closed
test(tracing): Add test to validate that spans only added when active span exists#10376AbhiPrasad wants to merge 5 commits intodevelopfrom
AbhiPrasad wants to merge 5 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Jan 26, 2024
247acb5 to
67296f1
Compare
mydea
added a commit
that referenced
this pull request
Jan 30, 2024
…#10386) This introduces a new `onlyIfParent` option to the start-span APIs, which, if set, will ensure to not create a span if there is no parent. I've added this also for otel to demonstrate this works there as well. This PR also uses this option in a few places, esp. for http.client spans, to ensure we do not capture these if there is no ongoing transaction. This replaces https://github.com/getsentry/sentry-javascript/pull/10375/files with a more generic solution, and includes the test from #10376 (which passes here as well).
Member
|
these have been picked & merged into #10386, so I'll close this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for #10375