fix(tracing): Only create request span if there is active span#10375
Merged
AbhiPrasad merged 6 commits intodevelopfrom Jan 29, 2024
Merged
fix(tracing): Only create request span if there is active span#10375AbhiPrasad merged 6 commits intodevelopfrom
AbhiPrasad merged 6 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
HazAT
approved these changes
Jan 26, 2024
mydea
approved these changes
Jan 26, 2024
Lms24
approved these changes
Jan 27, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Good catch! We should do a broader audit of where else this could be happening at the moment.
Contributor
Author
|
Contributor
Author
|
FINALLY |
This was referenced Jan 29, 2024
AbhiPrasad
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 30, 2024
https://github.com/getsentry/sentry-javascript/releases/tag/7.99.0 Notably it fixes a pretty bad SDK bug which caused inflated transaction volume - getsentry/sentry-javascript#10375
snigdhas
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jan 30, 2024
https://github.com/getsentry/sentry-javascript/releases/tag/7.99.0 Notably it fixes a pretty bad SDK bug which caused inflated transaction volume - getsentry/sentry-javascript#10375
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a regression introduced with #10236, we shouldn't arbitrarily call
startInactiveSpangiven we create transactions under the hood currently.