fix(node): LocalVariables integration should use setupOnce#10307
Merged
AbhiPrasad merged 5 commits intogetsentry:developfrom Jan 24, 2024
Merged
fix(node): LocalVariables integration should use setupOnce#10307AbhiPrasad merged 5 commits intogetsentry:developfrom
AbhiPrasad merged 5 commits intogetsentry:developfrom
Conversation
AbhiPrasad
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10278
This integration incorrectly used
setupwhich then caused issues when the core code was changed. It should have been usingsetupOnce.Unfortunately,
setupOncecauses issues with the unit tests since it then relies ongetClientto get the client instance for the client options. I've tried using jest to mockgetClientbut this doesn't work which is likely due toinstalledIntegrations.Because we already have extensive integration tests for LocalVariables I have removed the unit tests because they are becoming a maintenance burden and actually test less than the integration tests.
After v8, I plan to move Local variables lookup to the worker thread at which point we can revisit how these might be better tested in unit tests.