ref: Deprecate non-callback based continueTrace#10301
Merged
Conversation
Contributor
size-limit report 📦
|
7d429a5 to
ba77925
Compare
Base automatically changed from
lforst-start-span-read-prop-context
to
develop
January 30, 2024 07:01
1c58f58 to
9f5b9a4
Compare
continueTrace and its return valuecontinueTrace
AbhiPrasad
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates the non-callback based version of
continueTraceand migrates most our usages of it internally (In nextjs it's a bit complicated so I'll do it in a follow up pr). We deprecate this to err on the safe side in terms of otel because we might require to fork the scope/context in the future here and that would not be possible with a non-callback based implementation.