feat(replay): Deprecate Replay, ReplayCanvas, Feedback classes#10270
Merged
feat(replay): Deprecate Replay, ReplayCanvas, Feedback classes#10270
Conversation
Contributor
size-limit report 📦
|
billyvg
approved these changes
Jan 19, 2024
c298lee
approved these changes
Jan 19, 2024
Member
|
We should remember to update the usage of our class components inside of https://github.com/getsentry/getsentry after this is released (feedback + replay) |
Lms24
approved these changes
Jan 22, 2024
Instead, users should use the new functional styles. Note that we'll probably actually un-deprecate `Replay` in some form in v8, as we'll be keeping the class around there for sure (as there is a lot of logic in there...). But users should not use it, so deprecating this now!
5505ffd to
95fc8a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, users should use the new functional styles.
Note that we'll probably actually un-deprecate
Replayin some form in v8, as we'll be keeping the class around there for sure (as there is a lot of logic in there...). But users should not use it, so deprecating this now!While at it, I also deprecated the old
InitSentryForEmbermethod in favor ofinit().It's slightly unfortunate that I missed this, but we probably shouldn't have exposed
ReplayCanvasas a class anymore at all 😬 maybe we wait before we document this etc. until we merged the functional style. cc @billyvg