fix(astro): Fix import path when using external init files with default path#10214
Merged
fix(astro): Fix import path when using external init files with default path#10214
Conversation
Contributor
size-limit report 📦
|
Lms24
commented
Jan 17, 2024
Member
Author
There was a problem hiding this comment.
Had to add a second test file here to avoid globally mocking the fs.existsSync implementation for the other tests which relied on its default implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a pretty obvious bug in the Astro SDK where specifying an external
sentry.(client|server).config.jsin the default location file would cause a build error. Looks like this slipped through at some point and we didn't test it properly.Previously, we checked for a supported file extension and instead of adding an import statement for the path to the file, we'd only add the file extension. So
This PR fixes the filename lookup function and adds a test to cover regressions.
cc @HazAT