test(bun): Fix failing test after span.isRecording change#10136
Merged
test(bun): Fix failing test after span.isRecording change#10136
span.isRecording change#10136Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Jan 10, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
weird that this is reported so weirdly... 🤔
c298lee
pushed a commit
that referenced
this pull request
Jan 10, 2024
c298lee
pushed a commit
that referenced
this pull request
Jan 10, 2024
billyvg
pushed a commit
that referenced
this pull request
Jan 10, 2024
c298lee
pushed a commit
that referenced
this pull request
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why our Bun Unit Tests were still passing but locally as well as in CI somehow
else (weird) this test failed.
This failed in CI but I see no failed jobs 🤔
cc @mydea I think the test fix should be correct - in the
finishTransactiontest, thespan is already finished (hence, isRecording returns
false) butspanIsSampledshouldstill be true.