Skip to content

test(cloudflare): add example astro package#10108

Merged
anonrig merged 10 commits intodevelopfrom
add-cloudflare-astro
Jan 10, 2024
Merged

test(cloudflare): add example astro package#10108
anonrig merged 10 commits intodevelopfrom
add-cloudflare-astro

Conversation

@anonrig
Copy link
Copy Markdown
Contributor

@anonrig anonrig commented Jan 8, 2024 •
edited
Loading

Added a github workflow with missing properties:

      - name: Publish to Cloudflare Pages
        uses: cloudflare/pages-action@v1
        if: steps.cache_built_packages.outputs.cache-hit == ''
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }}
          directory: build
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}
          workingDirectory: dev-packages/env-tests/cloudflare-astro

@anonrig anonrig force-pushed the add-cloudflare-astro branch 2 times, most recently from 6c30e95 to a1ec2a0 Compare January 8, 2024 20:14
Lms24
Lms24 reviewed Jan 9, 2024
View reviewed changes
@Lms24
Copy link
Copy Markdown
Member

Lms24 commented Jan 9, 2024

General question: Is there a reason for making this its own workflow vs adding a job in our build.yml one?

@anonrig anonrig force-pushed the add-cloudflare-astro branch 6 times, most recently from 67efe18 to fe7bf59 Compare January 9, 2024 14:23
@anonrig anonrig marked this pull request as ready for review January 9, 2024 14:23
@anonrig anonrig force-pushed the add-cloudflare-astro branch 3 times, most recently from 07655be to a39349b Compare January 9, 2024 15:12
@anonrig anonrig force-pushed the add-cloudflare-astro branch from 56be3be to ffbc45a Compare January 10, 2024 15:47
Lms24
Lms24 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding this and for figuring out the resolution problems! We can also use this test app for some actual e2e tests later on so it's really valuable to have!

@anonrig anonrig enabled auto-merge (squash) January 10, 2024 17:24
@anonrig anonrig merged commit 84791bf into develop Jan 10, 2024
@anonrig anonrig deleted the add-cloudflare-astro branch January 10, 2024 17:30
c298lee pushed a commit that referenced this pull request Jan 10, 2024
@anonrig @c298lee
test(cloudflare): add example astro package (#10108)
73120dc
c298lee pushed a commit that referenced this pull request Jan 10, 2024
@anonrig @c298lee
test(cloudflare): add example astro package (#10108)
c35ad9b
billyvg pushed a commit that referenced this pull request Jan 10, 2024
@anonrig @billyvg
test(cloudflare): add example astro package (#10108)
284369a
c298lee pushed a commit that referenced this pull request Jan 10, 2024
@anonrig @c298lee
test(cloudflare): add example astro package (#10108)
92b9c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anonrig @Lms24