Skip to content

fix(node): Revert to only use sync debugger for LocalVariables#10077

Merged
lforst merged 3 commits intogetsentry:developfrom
timfish:fix/node-local-variables
Jan 5, 2024
Merged

fix(node): Revert to only use sync debugger for LocalVariables#10077
lforst merged 3 commits intogetsentry:developfrom
timfish:fix/node-local-variables

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Jan 5, 2024

This reverts the addition of an async debugger for the LocalVariables integration. Memory leaks were found in the new implimentation.

@timfish timfish requested a review from lforst January 5, 2024 13:27
Copy link
Copy Markdown
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Would you mind adding a quick PR description so that we know this is related to memory leakage? Thanks!

@lforst
Copy link
Copy Markdown
Contributor

lforst commented Jan 5, 2024

Thank you Tim! <3

@lforst lforst merged commit a443517 into getsentry:develop Jan 5, 2024
@timfish timfish deleted the fix/node-local-variables branch March 23, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants