feat(core): Add setClient() and getClient() to Scope#10055
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Jan 4, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
I think this is fine on it's own, the next thing we need to do is update getClient() to actually look clients up on the scopes, and fall back on the hub only if none exists there.
Contributor
Author
|
@mydea Right. Although I believe this would be dangerous to do right now... I think for all v7 releases we're better off still calling |
Member
|
Yeah it's probably right. We can change the semantic of this in V8, and keep it as-is for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a getter and setter for client objects to the Scope to align with the new Scope API. We also adjust the logic in the Hub constructor to correctly set the client on newly instantiated scope objects residing on the hub.