feat(core): Deprecate span toContext() and updateWithContext()#10030
Merged
feat(core): Deprecate span toContext() and updateWithContext()#10030
toContext() and updateWithContext()#10030Conversation
Contributor
size-limit report 📦
|
These APIs are not really used, and are not compatible with OpenTelemetry. So let's deprecate them for removal in v8.
cd839ba to
f0c5553
Compare
lforst
approved these changes
Jan 3, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
React native uses these but I think it is fine for us to deprecate them bc there is a migration path.
Lms24
approved these changes
Jan 3, 2024
anonrig
pushed a commit
that referenced
this pull request
Jan 3, 2024
…10030) These APIs are not really used, and are not compatible with OpenTelemetry. So let's deprecate them for removal in v8. Unless somebody knows a reason why we still need something like this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These APIs are not really used, and are not compatible with OpenTelemetry. So let's deprecate them for removal in v8.
Unless somebody knows a reason why we still need something like this?