fix(node): Handle inspector already open#10025
Merged
AbhiPrasad merged 2 commits intogetsentry:developfrom Jan 2, 2024
joshkel:anr-inspector
Merged
fix(node): Handle inspector already open#10025AbhiPrasad merged 2 commits intogetsentry:developfrom joshkel:anr-inspector
AbhiPrasad merged 2 commits intogetsentry:developfrom
joshkel:anr-inspector
Conversation
If the inspector is already running, then ANR should be able to (re)use that, instead of opening it itself. Fixes #10024
AbhiPrasad
reviewed
Jan 2, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you add a test case to https://github.com/getsentry/sentry-javascript/blob/develop/packages/node-integration-tests/suites/anr/test.ts?
|
|
||
| const testScriptPath = path.resolve(__dirname, 'basic.js'); | ||
|
|
||
| childProcess.exec(`node --inspect ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
Contributor
Author
|
@AbhiPrasad Done. Thank you. |
AbhiPrasad
approved these changes
Jan 2, 2024
anonrig
pushed a commit
that referenced
this pull request
Jan 3, 2024
If the inspector is already running, then ANR should be able to (re)use that, instead of opening it itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the inspector is already running, then ANR should be able to (re)use that, instead of opening it itself.
Fixes #10024
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).