-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Labels
Description
Linear ticket: https://linear.app/getsentry/issue/JS-1877
Depends on: #19677 (build output caching)
Parent: #19671
Goal
Extract browser integration test jobs (job_browser_playwright_tests, job_browser_loader_tests) from build.yml into an independent ci-browser-tests.yml workflow.
New workflow: ci-browser-tests.yml
name: 'CI: Browser Tests'
on:
push:
branches: [develop, master, v9, v8, release/**]
pull_request:
merge_group:
types: [checks_requested]
workflow_dispatch:Jobs
restore_build— uses.github/actions/restore-build(from CI: Build output caching + cross-workflow restore-cache action #19677) to get build output viaactions/cache/restorewith Nx-cached fallbackbrowser_playwright_tests— 13 bundle types × browsers, ESM sharded 4 ways (same as currentjob_browser_playwright_tests). Runs onubuntu-24.04-large-js.browser_loader_tests— 7 loader bundle variants (same as currentjob_browser_loader_tests). Runs onubuntu-24.04-large-js.browser_tests_gate— gate job namedBrowser Tests Passed, checks all above jobs
Playwright caching
The .github/actions/install-playwright composite action handles Playwright browser caching. This already uses actions/cache and works cross-workflow. No changes needed.
Conditional execution
Current jobs check changed_browser_integration to skip when browser integration test files haven't changed. This workflow needs the same logic — either inline the change detection or call reusable-metadata.yml.
Transition steps
- Create
ci-browser-tests.yml. Browser tests now run in bothbuild.ymlandci-browser-tests.yml(dual-running). - Verify stability over several days/PRs.
- Ruleset change (requires admin): Add
Browser Tests Passedas required status check to all 4 rulesets. - Remove
job_browser_playwright_tests,job_browser_loader_testsfrombuild.ymland fromjob_required_jobs_passedneeds list.
Concurrency
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: trueReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Fields
Give feedbackNo fields configured for issues without a type.