Skip to content

Add support for setting in-app-includes/in-app-excludes via AndroidManifest.xml#4240

Merged
markushi merged 2 commits into
mainfrom
markushi/fix/support-for-in-app-includes-excludes-manifest
Mar 7, 2025
Merged

Add support for setting in-app-includes/in-app-excludes via AndroidManifest.xml#4240
markushi merged 2 commits into
mainfrom
markushi/fix/support-for-in-app-includes-excludes-manifest

Conversation

@markushi

@markushi markushi commented Mar 7, 2025

Copy link
Copy Markdown
Member

📜 Description

We officially support it according to our docs, but actually it's not implemented.

💡 Motivation and Context

Fixes #2617

💚 How did you test it?

Added tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions

github-actions Bot commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.78 ms 463.80 ms 72.02 ms
Size 1.58 MiB 2.21 MiB 642.10 KiB

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should update the configuration/options.mdx docs of both java and android as they refer to in-app-include(/exclude) where it should be plural in-app-includes instead

@markushi

markushi commented Mar 7, 2025

Copy link
Copy Markdown
Member Author

LGTM, we should update the configuration/options.mdx docs of both java and android as they refer to in-app-include(/exclude) where it should be plural in-app-includes instead

Docs PR is up as well now: getsentry/sentry-docs#12954

@markushi markushi merged commit 7074d0b into main Mar 7, 2025
@markushi markushi deleted the markushi/fix/support-for-in-app-includes-excludes-manifest branch March 7, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InAppInclude option not added via AndroidManifest.xml

2 participants