Close backpressure monitor on SDK shutdown#3998
Merged
Conversation
…the ScopesStorage is initialized
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Close backpressure monitor on SDK shutdown ([#3998](https://github.com/getsentry/sentry-java/pull/3998))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 33c9aac | 393.47 ms | 407.26 ms | 13.79 ms |
| b387fed | 417.02 ms | 519.06 ms | 102.04 ms |
| c658b5a | 410.55 ms | 461.18 ms | 50.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 33c9aac | 1.65 MiB | 2.31 MiB | 677.05 KiB |
| b387fed | 1.65 MiB | 2.31 MiB | 677.07 KiB |
| c658b5a | 1.65 MiB | 2.31 MiB | 677.05 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Close backpressure monitor on SDK shutdown
💡 Motivation and Context
Due to the backpressure monitor rescheduling a task at 10s intervals, there's a very high chance of a task currently being scheduled at any time that takes longer than the
shutdownTimeoutMillis(defaulting to 2s) before it'll run. When the SDK shuts down, it'll first ask theScheduledExecutorServiceto shutdown, not accepting any more new scheduled jobs but giving already scheduled jobs a chance to run. This means the SDK shutdown will almost always be delayed by the backpressure monitors scheduled job before it forcefully shuts downScheduledExecutorServiceafter waitingshutdownTimeoutMillis💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps