Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
stefanosiano
approved these changes
Nov 28, 2024
Contributor
stefanosiano
left a comment
There was a problem hiding this comment.
from what i can tell it's fine
I guess the move of the dependencyManagement block to the noagent gradle file is wanted, right? 😅
Collaborator
|
@adinauer The system tests seem to be failing though |
Collaborator
Member
Author
|
Yes, some tests were failing because "no agent" didn't work with the new OTel version. It's fixed in the POTEL 60 PR. |
Member
Author
Yes, this is intentional as OTel suggests to add this config when using the spring boot otel starter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Bump OpenTelemetry SDK to
1.44.1, OpenTelemetry instrumentation to2.10.0and OpenTelemetry semantic conventions to1.28.0💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps