POTEL 53 - Automatically set span factory based on presence of OpenTelemetry#3858
Merged
POTEL 53 - Automatically set span factory based on presence of OpenTelemetry#3858
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
Base automatically changed from
feat/no-agent-sample-fix-ignored-instrumentation
to
8.x.x
November 11, 2024 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Previously
OtelSpanFactoryhad to be set by an integration or the customer (manually). The SDK now auto detects the presence ofOpenTelemetryand then setsOtelSpanFactoryby default.Also
SentrySpanFactoryHolderis no longer needed (since we moved classes into the bootstrap classloader) and has been removed.There is now a
system-test-run.shscript to run all system tests locally without having to build the command manually.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps