Skip to content

POTEL 52 - Do not ignore certain span origins for OTel without Agent#3856

Merged
adinauer merged 7 commits into8.x.xfrom
feat/no-agent-sample-fix-ignored-instrumentation
Nov 11, 2024
Merged

POTEL 52 - Do not ignore certain span origins for OTel without Agent#3856
adinauer merged 7 commits into8.x.xfrom
feat/no-agent-sample-fix-ignored-instrumentation

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented Nov 7, 2024

📜 Description

  • Do not ignore certain span origins for OTel without Agent
  • Add a separate sample for "no agent" use case

💡 Motivation and Context

  • Not all auto instrumentation is there for the Spring setup without an agent
  • Avoids having to change a single sample back and forth.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…or no agent

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 52 - Do not ignore certain span origins for OTel without Agent ([#3856](https://github.com/getsentry/sentry-java/pull/3856))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 047159c

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.02 ms 428.47 ms 34.45 ms
Size 1.65 MiB 2.31 MiB 672.58 KiB

Previous results on branch: feat/no-agent-sample-fix-ignored-instrumentation

Startup times

Revision Plain With Sentry Diff
295289b 470.16 ms 498.78 ms 28.62 ms

App size

Revision Plain With Sentry Diff
295289b 1.70 MiB 2.36 MiB 670.63 KiB

Copy link
Copy Markdown
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR target feat/otel-classloader-fix instead?


@Test
@Config(sdk = [30])
// @Test
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to re-enable this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed with merging main into this branch. Will re-enable in a follow up PR.

Base automatically changed from feat/spring-boot-autoconfig-for-otel-no-agent to 8.x.x November 11, 2024 14:53
@adinauer adinauer changed the base branch from 8.x.x to feat/otel-classloader-fix November 11, 2024 15:04
Base automatically changed from feat/otel-classloader-fix to 8.x.x November 11, 2024 15:20
@adinauer adinauer mentioned this pull request Nov 11, 2024
@adinauer adinauer merged commit ca3da4b into 8.x.x Nov 11, 2024
@adinauer adinauer deleted the feat/no-agent-sample-fix-ignored-instrumentation branch November 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants