Conversation
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Co-authored-by: Stefano <stefano.siano@sentry.io>
Co-authored-by: Stefano <stefano.siano@sentry.io>
Co-authored-by: Stefano <stefano.siano@sentry.io>
Co-authored-by: Stefano <stefano.siano@sentry.io>
Co-authored-by: Stefano <stefano.siano@sentry.io>
…e difference of .equals if objects are not the same
…va into feat/lazy-span-id-v8
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- SessionID as string ([#3834](https://github.com/getsentry/sentry-java/pull/3834))If none of the above apply, you can opt out of this check by adding |
romtsn
reviewed
Nov 4, 2024
| } catch (IllegalArgumentException e) { | ||
| logger.log(SentryLevel.ERROR, "%s sid is not valid.", sidString); | ||
| String sid = reader.nextStringOrNull(); | ||
| if (sid != null && sid.length() == 32) { |
Member
There was a problem hiding this comment.
should we still keep the log call in the else branch?
romtsn
reviewed
Nov 4, 2024
| final int errorCount, | ||
| final @Nullable String distinctId, | ||
| final @Nullable UUID sessionId, | ||
| final @Nullable String sessionId, |
Member
There was a problem hiding this comment.
do we have to apply some validation still that this is compliant with the uuid format?
romtsn
approved these changes
Nov 4, 2024
Member
romtsn
left a comment
There was a problem hiding this comment.
couple of comments to address, but lgtm otherwise
…ce when invoking with string
…-java into feat/fast-id-generation
…to SentryId constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Follow-up to #3818
💡 Motivation and Context
Replace usage of
UUIDinSessionwith String and generate ID usingSentryUUIDclass.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps