Skip to content

POTEL 37d - Bump OpenTelemetry versions#3668

Merged
adinauer merged 12 commits into8.x.xfrom
feat/potel-37d-bump-otel-versions
Sep 3, 2024
Merged

POTEL 37d - Bump OpenTelemetry versions#3668
adinauer merged 12 commits into8.x.xfrom
feat/potel-37d-bump-otel-versions

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented Aug 29, 2024

📜 Description

            val otelVersion = "1.41.0"
            val otelJavaagentVersion = "2.7.0"
            val otelSemanticConvetionsVersion = "1.25.0-alpha"

Sticking to semconv 1.25.0 as https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/dependencyManagement/build.gradle.kts#L49 hasn't upgraded yet.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4de7284

@adinauer adinauer mentioned this pull request Aug 29, 2024
Closed
7 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.98 ms 429.83 ms 25.85 ms
Size 1.70 MiB 2.29 MiB 599.45 KiB

Previous results on branch: feat/potel-37d-bump-otel-versions

Startup times

Revision Plain With Sentry Diff
bf6dbe7 398.44 ms 468.30 ms 69.86 ms
aa74a22 519.46 ms 602.02 ms 82.56 ms

App size

Revision Plain With Sentry Diff
bf6dbe7 1.70 MiB 2.29 MiB 599.31 KiB
aa74a22 1.70 MiB 2.29 MiB 599.31 KiB

lbloder
lbloder approved these changes Sep 2, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Have all instrumentations moved to the new incubating Attributes? Does it actually matter, as the types and keys stay the same

@adinauer
Copy link
Copy Markdown
Member Author

adinauer commented Sep 3, 2024

I just tested it and the following code shows that it cares about the underlying string, not where the reference is coming from:

otelSpan.setAttribute(InternalSemanticAttributes.TEST1, "test1");
otelSpan.setAttribute(InternalSemanticAttributes.TEST2, "test2");

String test1 = span.getAttributes().get(InternalSemanticAttributes.TEST1);
System.out.println(test1); // prints "test2"
String test2 = span.getAttributes().get(InternalSemanticAttributes.TEST2);
System.out.println(test2); // prints "test2"

I wasn't able to find any usage of the "old" SemanticAttributes class in the opentelemetry-java-instrumentation code base for v2.7.0 anymore. In older versions it was still being used.

Base automatically changed from feat/potel-37c-skip-process-command-args-attribute to 8.x.x September 3, 2024 10:35
An error occurred while trying to automatically change base from feat/potel-37c-skip-process-command-args-attribute to 8.x.x September 3, 2024 10:35
@adinauer adinauer merged commit e5f1ac5 into 8.x.x Sep 3, 2024
@adinauer adinauer deleted the feat/potel-37d-bump-otel-versions branch September 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @lbloder @getsentry-bot