POETL 37c - Skip PROCESS_COMMAND_ARGS attribute#3664
Merged
Conversation
# Conflicts: # sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SpanDescriptionExtractor.java
…noring sentry specific ones
…PROCESS_COMMAND_ARGS
Contributor
|
Contributor
Performance metrics 🚀
|
lbloder
approved these changes
Sep 2, 2024
Collaborator
lbloder
left a comment
There was a problem hiding this comment.
LGTM 👍
One minor thing, since we now add an external key to the list, maybe the method isSentryInternalKey could be renamed to something more fitting like shouldAttributeBeRemoved or similar
Base automatically changed from
feat/potel-37b-remove-selective-attribute-copying
to
8.x.x
September 3, 2024 10:28
An error occurred while trying to automatically change base from
feat/potel-37b-remove-selective-attribute-copying
to
8.x.x
September 3, 2024 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
PROCESS_COMMAND_ARGScan be very large and cause other payload to be removed.💡 Motivation and Context
Defaults that work for most users.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps